Add support for `firestoreDataAccessMode`, `mongodbCompatibleDataAcessMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource #16242

NickChittle · 2026-01-27T21:12:26Z

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

firestore: Add support for `firestoreDataAccessMode`, `mongodbCompatibleDataAcessMode`, and `realtimeUpdatesMode` parameters in the `google_firestore_database` resource

…de, and realtimeUpdatesModes parameters in the google_firestore_database resource

github-actions · 2026-01-27T21:13:33Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-01-27T21:23:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 93 insertions(+))
google-beta provider: Diff ( 3 files changed, 93 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firestore_database (33 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firestore_database" "primary" {
  firestore_data_access_mode          = # value needed
  mongodb_compatible_data_access_mode = # value needed
  realtime_updates_mode               = # value needed
}

modular-magician · 2026-01-27T21:31:24Z

Tests analytics

Total tests: 30
Passed tests: 30
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-01-27T21:37:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

modular-magician · 2026-01-27T21:43:12Z

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-27T21:43:30Z

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/templates/terraform/examples/firestore_database_data_access.tf.tmpl

rwhogg · 2026-01-28T16:20:23Z

mmv1/products/firestore/Database.yaml

+  - name: 'firestoreDataAccessMode'
+    type: Enum
+    description: |
+      The Firestore API data access mode to use for this database.


What happens if one of these is set for a Datastore mode database? (Same question about Mongo-compat API for Datastore mode).

And if the Firestore API data access mode is enabled, does that allow using the Datastore API against that database?

These are blocked by the backend.

Trying to create an ENTERPRISE database in datastore-mode throws this error:
INVALID_ARGUMENT: Enterprise Edition is only supported for Firestore Native databases.

Trying to create a STANDARD database datastore-mode with one of the data-access modes throws this error:
INVALID_ARGUMENT: Only Enterprise Edition is allowed to set Data Access Mode.

Gotcha. In that case let's just leave something in the descriptions specifying the allowed editions and modes.

modular-magician · 2026-01-28T16:49:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

modular-magician · 2026-01-28T16:58:37Z

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-28T16:58:54Z

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-28T19:05:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

modular-magician · 2026-01-28T19:09:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 149 insertions(+))
google-beta provider: Diff ( 4 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

modular-magician · 2026-01-28T19:12:47Z

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-28T19:13:28Z

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-28T19:17:46Z

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-28T19:18:19Z

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-28T19:22:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 150 insertions(+))
google-beta provider: Diff ( 4 files changed, 150 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

modular-magician · 2026-01-28T19:29:27Z

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-28T19:30:02Z

🔴 Tests failed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-28T21:09:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 151 insertions(+))
google-beta provider: Diff ( 4 files changed, 151 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

modular-magician · 2026-01-28T21:18:28Z

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-28T21:19:23Z

🟢 Tests passed during RECORDING mode:
TestAccFirestoreDatabase_firestoreDatabaseDataAccessExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMo…

bdb70cc

…de, and realtimeUpdatesModes parameters in the google_firestore_database resource

github-actions bot requested a review from roaks3 January 27, 2026 21:13

modular-magician added the service/firestore-controlplane label Jan 27, 2026

Fix template usage

0714034

rwhogg reviewed Jan 28, 2026

View reviewed changes

mmv1/templates/terraform/examples/firestore_database_data_access.tf.tmpl Outdated Show resolved Hide resolved

rwhogg reviewed Jan 28, 2026

View reviewed changes

Fix tab/space alignment

871cbaf

NickChittle added 2 commits January 28, 2026 18:53

Fix template

9e34ab5

Fix template oopsie

cf471e5

Small fixes

1bb52d5

Make sure example database is able to be deleted

6b6c704

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource #16242

Are you sure you want to change the base?

Add support for firestoreDataAccessMode, mongodbCompatibleDataAcessMode, and realtimeUpdatesMode parameters in the google_firestore_database resource #16242

Conversation

NickChittle commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

modular-magician commented Jan 27, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 27, 2026

Tests analytics

Uh oh!

modular-magician commented Jan 27, 2026

Diff report

Uh oh!

modular-magician commented Jan 27, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 27, 2026

Uh oh!

Uh oh!

rwhogg Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

NickChittle Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

rwhogg Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jan 28, 2026

Diff report

Uh oh!

modular-magician commented Jan 28, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 28, 2026

Uh oh!

modular-magician commented Jan 28, 2026

Diff report

Uh oh!

modular-magician commented Jan 28, 2026

Diff report

Uh oh!

modular-magician commented Jan 28, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 28, 2026

Uh oh!

modular-magician commented Jan 28, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 28, 2026

Uh oh!

modular-magician commented Jan 28, 2026

Diff report

Uh oh!

modular-magician commented Jan 28, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 28, 2026

Uh oh!

modular-magician commented Jan 28, 2026

Diff report

Uh oh!

modular-magician commented Jan 28, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 28, 2026

Uh oh!

Add support for `firestoreDataAccessMode`, `mongodbCompatibleDataAcessMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource #16242

Add support for `firestoreDataAccessMode`, `mongodbCompatibleDataAcessMode`, and `realtimeUpdatesMode` parameters in the google_firestore_database resource #16242

NickChittle commented Jan 27, 2026 •

edited

Loading